Metrics API scaler to support parsing numbers in quotes as well as quantities. #1668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
force-pushed
the
main
branch
2 times, most recently
from
306226f to
c5de4c2
Compare
Quantity is returned as a member of ExternalMetricValue so there should be no impact. Signed-off-by: Joe Shearn <joseph.shearn@sainsburys.co.uk>
|
@turbaszek would you mind looking at this? |
turbaszek
reviewed
Mar 15, 2021
pkg/scalers/metrics_api_scaler.go
Outdated
| r := gjson.GetBytes(body, valueLocation) | ||
| if r.Type == gjson.String { | ||
| q, err := resource.ParseQuantity(r.String()) | ||
| if err == nil { |
There was a problem hiding this comment.
What will be returned if the err!=nil?
There was a problem hiding this comment.
It would revert to the original behaviour and return "valueLocation must point to value of type number got: string"
turbaszek
reviewed
Mar 15, 2021
|
@devjoes could you please open another PR with documentation of this feature? in content/docs/2.2 https://github.com/kedacore/keda-docs |
Signed-off-by: Joe Shearn <joseph.shearn@sainsburys.co.uk>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quantities can now be parsed from a metrics API response. Lots of metrics APIs return Quantity types which get marshalled to strings (KEDA itself actually has this behaviour).
ExternalMetricValue.Value is already a Quantity so there should be no impact on the wider codebase.
Checklist
Fixes #1667